search

vanessa-kang / pe

0 stars 0 forks source link

Validation of foreign currency abbreviation is not carried out #6

Open vanessa-kang opened 3 years ago

vanessa-kang commented 3 years ago

There does not seem to be validation of the foreign currency abbreviation. For example: PPP is not an internationally valid abbreviation, but I was able to add it anyway.

image.png

nus-pe-bot commented 3 years ago

Team's Response

This is done intentionally as the team is looking to reduce the file size of Trippie to optimize its processing speed for our users.

Thank you for your feedback.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Accuracy of information provided is an area that should not be compromised on. If such input is not validated, it allows the user to input rubbish values that potentially compromise the data integrity and correctness of their trip information. This makes the program no better than using an Excel sheet, of which the latter may in fact offer more flexibility and customisation.

I agree that tradeoffs sometimes have to be made, but I feel that it is inappropriate for it to be done between information accuracy and program optimisation. There are better areas in which to hunt for speed improvements instead.

Additionally, as stated on the module website, the maximum allowed JAR file size is 100MB. Since the size of your JAR file is currently 56KB, that leaves plenty of space for such information to be included without adversely affecting storage or processing speed. image.png