search

vanessa-luna / banner-comments-plus

Figlet Font Code Comments (ascii fonts)
MIT License
14 stars 4 forks source link

Does not work in a .sh file #5

Open wiraki opened 5 years ago

wiraki commented 5 years ago

Unfortunately, applying a banner comment does not work if a file's extension is .sh

Any ideas how to solve this?

vanessa-luna commented 4 years ago

I had no idea people were commenting on this. Sorry I never got to you.

If I get aorund to it this winter I will udpate and try my hand a .sh files. May have something to do with the languageConfig, may be missing something I am looking for and I don't sanitized properly.

Thank you for letting me know.

danielgul commented 4 years ago

I can confirm that banner comments do work for me on *.sh files. Using Code OSS v1.44.2 on Manjaro Linux v20.

haakonstorm commented 3 years ago

Was looking forward to this, I only use VS Code for writing shell scripts (.sh .bash .zsh .command are all 'valid' on macOS) please have a look at this - I'm sure its just a missing token somewhere. Bug reported now close to a year ago, perhaps we can have a 1 year anniversary fixing it? :-)

haakonstorm commented 3 years ago

PS: All other formats work then I try, javascript, etc.