wenzhengzzz
commented
6 years ago Hi @vanflad, Thanks for inviting me to your repository. First of all, good choice on pictures in your markdown and readme file! Here are more specific comments:
--Well organized homework. It is grateful that you explain your process clearly in your Rmd file and linked each file to README file, which is quite useful when I review your homework.
--You made API queries "by hand" using the httr packag in this assignment, while I did not choose the same task though, I learned a lot from your homework. And I found the link to Internet Video Archive (IVA)'s Entertainment Express API is very useful. Thank you.
--when you get Id, episode, title and date info for every season and episode, you used a complicated for loop, which might be confusing when read it.
-- the only suggestion that I could think of is to useinclude=FALSE or warning=FALSE to avoid unnecessary messages.
Overall, I think you did a great job!
Hi @vanflad
Here are some thoughts on your hw10:
First thing I noticed is that your repo and assignment are very well organized. Lots of text and comments in the code to describe whats going on.
Nice note about API limits. It's easy not pay attention to this sort of thing only to run into trouble once it maxes out.
It would be nice to use
suppressPackageStartupMessages()when loading packages prevent the start up messages from cluttering your .md file, though the comments are goodThat's a complicated but clever for loop to go iterate over the seasons and episodes
I'm not sure what was happening with the
Request failed [429]. Retrying in 1 seconds...but it looks like youralwayssunny$Descriptionworked in the end.Thanks for teaching me about cowplot! I love it and will definitely use it in the future
Overall your code shows expert R proficiency and the graphs look very nice!
Cheers, Sep