Open vanflad opened 7 years ago
Peer review by Ziming.
In homework readme file you did a good job adding HW1 and HW2 link into it, and I like the ocean.gif, looks beautiful and peaceful. You also makes the page nice-looking by adjusting fonts in various way( learned how to type a quote in your way :P ). Just one more thing I think it would be great it you also make a folder for HW1 and just put a link inside readme, thus later when you add more HW files it would be tidy.
HW2 readme reminds me of my own struggles at the beginning! I used some time to figure out the sub-folder thing too and finally realized I could do it in my local computer and then push, good you also figured out!
So I checked your .md file, good job finishing those task. You showed great skills in plot and make tables. Btw in the last figure you may want to use alpha to make it kind of transparent thus upper layer wouldn't cover lower.
Overall, your assignment followed the requirements and even more. Good job and all the best with future assignments.
Hi @vanflad The README.md for your hw02 is looking really good. I appreciate how you include appropriate links, which enhances the overview and navigational experience a lot.
The layout of your content in the README.md file is nicely organized and you demonstrate that you have a good sense for creating a readable text with the use of different headers and font styles. I totally get what you're saying about your problem in organizing the files in the appropriate folder, I had some struggle with that myself. You showed that you where determined in understanding how this works and it all turned out very well.
Like the previous peer review stated you did a really good job and followed the requirements and you executed this assignment with accuracy and finesse. In your "small testing data " section you used the is
function. Instead of inspecting every possible data type of the data set, a faster way would be to execute the typeof()
argument instead (which would return the values immediately) There are many ways to tackle the different tasks and your approach works just as good.
You did a really good job with exploring different plot types. Overall I'm impressed with your approach to solve this assignment. Keep it up and I wish you the best of luck with your future assignments.
Cheers!
@vincenzocoia @gvdr @ksedivyhaley @joeybernhardt @mynamedaike @pgonzaleze @derekcho