vanflad / STAT547-hw-fladmark-vanessa

0 stars 0 forks source link

hw02 ready for grading! #2

Open vanflad opened 7 years ago

vanflad commented 7 years ago

@vincenzocoia @gvdr @ksedivyhaley @joeybernhardt @mynamedaike @pgonzaleze @derekcho

jardnzm commented 7 years ago

Peer review by Ziming.

Overall, your assignment followed the requirements and even more. Good job and all the best with future assignments.

mattssca commented 7 years ago

Hi @vanflad The README.md for your hw02 is looking really good. I appreciate how you include appropriate links, which enhances the overview and navigational experience a lot.

The layout of your content in the README.md file is nicely organized and you demonstrate that you have a good sense for creating a readable text with the use of different headers and font styles. I totally get what you're saying about your problem in organizing the files in the appropriate folder, I had some struggle with that myself. You showed that you where determined in understanding how this works and it all turned out very well.

Like the previous peer review stated you did a really good job and followed the requirements and you executed this assignment with accuracy and finesse. In your "small testing data " section you used the is function. Instead of inspecting every possible data type of the data set, a faster way would be to execute the typeof() argument instead (which would return the values immediately) There are many ways to tackle the different tasks and your approach works just as good.

You did a really good job with exploring different plot types. Overall I'm impressed with your approach to solve this assignment. Keep it up and I wish you the best of luck with your future assignments.

Cheers!