hw04 ready for grading!

vanflad / STAT547-hw-fladmark-vanessa

0 stars 0 forks source link

hw04 ready for grading! #4

Open vanflad opened 7 years ago

ilgan commented 7 years ago

Very good work Vanessa @vanflad !

The HW is clean written, with informative comments that show the understanding of the joins applications.
Graphs are informative.
ReadMe file is nicely summarized, and included all the issues that you've faced and how you resolved them.
I liked the fact that you created your own data base.

Side Note

You can use {r message=FALSE} to suppress unwanted output from the R chunk.
You can save created data base for future use.

Very good work!

burkeprw commented 7 years ago

Hi @vanflad! I am here for peer review.

Your homework was a good review of spread() and the join functions in 'dplyr'. The Markdown was well laid out and easy to follow. Your knitr::kable() tables looked great. And nice work getting Git and client up and running on a new machine -- I bet that was a pain.

A few comments and suggestions:

Consider using suppressPackageStartupMessages(library(...)) to make the Markdown more readable.
Consider using backticks ( ` ) around functions or other inline code in Markdown for readability

I learned that the PC shortcut for a code chunk in R is ALT + CTL + i. Thanks!! I've been wondering about this. Unfortunately, this gives me an accented "í". I think I need to change my system settings to correct this. Also, thanks to @ilgan, for the tip about suppressing unwanted material in Markdown.

derekcho commented 6 years ago

Hi @vanflad, here are some comments about your hw04:

The first task was done very well! You provided a nice plot containing the data in the tables that you reshaped from gapminder. You provided good demonstrations of the spread function. Good job!
Interesting data choice for your cheatsheet! I think that it would be good to present the full data in table form in the beginning rather than in text form like you did. It would make it easier for the reader to tell the differences before and after joining the tables. Also, it would be more organized if you kept the different types of joins in a logical order such. In your report, they seem to be in a random order. However, you did a good job showing the results of each kind of join and provided good explanations to compliment them as well.
Your report was neat and well organized
Your repo is clean and easy to navigate
Coding style is efficient and easy to read
Nice work overall!

Your grade will be emailed to you at a later date.