hw09 ready for grading!

[heathersummers]

Hi Vanessa,

Good work on the assignment it was great to see you added two new functions to the existing powers package (i.e. cube and reciprocal). I had no issues when downloading or using your package (i.e. no errors or warnings)! I would suggest making sure that your package Powers is in a new repository and not within your STAT547 repository. It was great to see that you expanded on the existing functions within the powers package (i.e. square and pow) and you documented all exported functions and had assertions for validity checks. I found it really interesting how you added the figures to visually represent some of the common exponential power transformations. I believe the README and vignette could have been more informative with at least a single sentence summary of each of the functions instead of just an example. I would also suggest adding more testthat expressions for each of the functions you created. I found this website helpful for getting more information on testthat functions. Lastly, I wasn’t able to find your reflection so I am not sure if I have just missed it or you didn’t write one. Overall, good work on this assignment and best of luck with the last assignment!

Heather

[emilymistick]

Hi @vanflad

Thanks for sharing your homework. Your README is really clear with links to all of the assignment pieces. Thanks for making it easy to navigate. I was able to download and use your package with no problems, awesome.

Your package downloads and works great! However, the sample powers package already includes cube and reciprocal doesn't it? so I don't see any new functions added. A reflection would've helped clarify what was new vs. what was in the forked package.

You did add some functionality to the package though in the form of informative plots on the vignette. You also set up nice error messages for wrong inputs, which looks great!

This was a difficult homework. I struggled a bit with testthat also. Looks like the site Heather suggested is a good resource if needed in the future.

Best, Emily

[derekcho]

Hi @vanflad, here are some comments about your hw09:

Able to install properly: Yes At least one new function: No Used assertions to check function input: Yes Documented exported functions: Yes Includes three unit tests for each function: No (only one per function) Passes check: Yes README and vignette: Yes Reflections included: No

• I was able to download and install your package without any problems
• Your package does not feature any new functions, only those given by Vincenzo although they were split into different files
• Assertions were implemented well. Error messages are informative
• Some unit testing was done, but does not meet the recommended criteria of at least three per function
• README was good, it has an appropriate level of detail. However, the package vignette could use a bit more. You provide plenty of examples of the functions but you should try to provide additional details about your package here.

Your grade will be emailed to you at a later date.