Code Review 2

[yangdavid1985]

Design/Code Review 2

Project: Personal Finance Tracker

Developer: Kyle

Reviewer: David Yang

Category	Criteria	Analysis/Comments
Running application
	Describe the application functionality that has been built and is working.	N/A
	What is good?
	What could be improved?	Adding link to project
Unit Tests
	What are the code coverage statistics?	N/A
	Are @Before/@BeforeClass/@After/@AfterClass used to reduce redundant code?	Yes
JSPs
	Is templating used to eliminate rundandant code(for example, header.jsp, footer.jsp, etc.)	Yes
	What is good?	head.jsp template used to eliminate redundant code
	What could be improved?
Code quality
	Are methods single-purpose?	Yes
	Are classes appropriately-sized classes (no monster classes)?	yes
	Are the same lines of code repeated at all?	no
	Do any classes perform very similar functions that could be candidates for super/subclass relationships?	no
	Are any values hard-coded that should be in a properties file?	no
	Are variable names descriptive?	yes
	Are there many branches or loops that could be simplified or broken up into smaller methods?	no
	Do the DAOs use Hibernate? No hard-coded sql!	yes
	Has log4J been added?	yes
	Are there logging statements in the code?	yes
	Are appropriate logging levels used? Info, debug, error, for example.	yes, some
	Are there any System.out.printlns in the code?	no
	Other comments/notes?
Web Service/API integration	Which web service/api is being used?	Google login
	Is the integration built?	no
	If so, evaluate the integration code. What is good? What could use improvement?
Independent research topic	What is the developer's independent research topic?	N/A
	Has the topic been implemented in the project?	N/A
	If so, evaluate the implementation. What is good? What could use improvement?
Key takeaways	List at least 3 things you learned while reviewing this project that will help you in your own project.

[pawaitemadisoncollege]

Review is missing some detail - what functionality is implemented to date? What did you learn from this review? What is the independent research topic? Is it implemented? It might be that you will need to check in with the developer for a demo or more details if you are unsure where to look for some pieces.

[yangdavid1985]

I will message Kyle to see when he has free time for a demo.