search

vangkyle / PersonalFinance

Tracking personal finance
0 stars 0 forks source link

javaneil code review #6

Open javaneil opened 7 years ago

javaneil commented 7 years ago

Design/Code Review 2

Project:

Finance Tracker https://github.com/vangkyle/PersonalFinance

Developer:

Kyle Vang

Reviewer:

Neil Fortney (JavaNeil)

Category Criteria Analysis/Comments
Running application
Describe the application functionality that has been built and is working.
What is good?
What could be improved?
Unit Tests
What are the code coverage statistics?
x Are @Before/@BeforeClass/@After/@AfterClass used to reduce redundant code? @Before
JSPs
X Is templating used to eliminate rundandant code(for example, header.jsp, footer.jsp, etc.) yes
What is good?
What could be improved?
Code quality
x Are methods single-purpose? yes
x Are classes appropriately-sized classes (no monster classes)? yes
x Are the same lines of code repeated at all? no
Do any classes perform very similar functions that could be candidates for super/subclass relationships?
Are any values hard-coded that should be in a properties file?
Are variable names descriptive?
Are there many branches or loops that could be simplified or broken up into smaller methods?
x Do the DAOs use Hibernate? No hard-coded sql! yes
x Has log4J been added? yes
x Are there logging statements in the code? yes
x Are appropriate logging levels used? Info, debug, error, for example. yes
x Are there any System.out.printlns in the code? none found
x Other comments/notes? javadocs headers. Some commented-out code that should be cleaned-up before production release
Web Service/API integration Which web service/api is being used? TBD
Is the integration built?
If so, evaluate the integration code. What is good? What could use improvement?
Independent research topic What is the developer's independent research topic?
Has the topic been implemented in the project?
If so, evaluate the implementation. What is good? What could use improvement?
Key takeaways List at least 3 things you learned while reviewing this project that will help you in your own project.
pawaitemadisoncollege commented 7 years ago

Review is missing some detail - what functionality is implemented to date? What did you learn from this review? What is the independent research topic? Is it implemented? It might be that you will need to check in with the developer for a demo or more details if you are unsure where to look for some pieces.