search

vangoghworldwide / linkedart

Documentation on the use of linkedart - with examples
11 stars 1 forks source link

Dimension values must be numbers #38

Closed IllyaMoskvin closed 2 years ago

IllyaMoskvin commented 2 years ago

Looking at this example:

https://github.com/vangoghworldwide/linkedart#dimensions

The values are given as strings ("51.9" and "36.4").

However, checking the Linked Art Schema docs:

https://linked.art/api/1.0/schema_docs/object/

It looks like value is defined as Type:number.

Do you care whether we supply value as string or number in the JSON?

michielhildebrand commented 2 years ago

At the moment we allow string and number. We don't compute anything with dimensions (yet). I agree with you that the example in the documentation should use number, just in case we want to compute with dimensions in the future.