idr requires numpy<1.20

vanheeringen-lab / seq2science

Automated and customizable preprocessing of Next-Generation Sequencing data, including full (sc)ATAC-seq, ChIP-seq, and (sc)RNA-seq workflows. Works equally easy with public as local data.

https://vanheeringen-lab.github.io/seq2science

MIT License

155 stars 27 forks source link

idr requires numpy<1.20 #996

Closed Maarten-vd-Sande closed 1 year ago

Maarten-vd-Sande commented 1 year ago

What problem is the PR solving / What's new?

see #995

Checklist

[x] I made a PR to develop (not master)
[ ] If applicable: I updated the docs
[x] I updated the CHANGELOG
[ ] These changes are covered by the tests

Maarten-vd-Sande commented 1 year ago

Yeah I wasn't sure what would be best or necessary. For the new build I pinned the python version lower than 3.9, I am not sure what conda prefers. The newer build or the same python (3.10) version. So I thought just to be safe I pin numpy in the idr environment as well. Pinning the idr should also work. I think the downstream effect is (hopefully) all the same though. :smile: