Late Submission from CoderSchool Alumnus

vanhensy / RoRTraining-Prework

Prework for Ruby Class at Coderschool

0 stars 0 forks source link

Late Submission from CoderSchool Alumnus #1

Open chug2k opened 8 years ago

chug2k commented 8 years ago

Vy you need to submit!

@coderschoolreview

coderschoolreview commented 8 years ago

Thank you for your Rails submission, vanhensy!

:tired_face: Unfortunately there are some problems with your submission:

I couldn't find a walkthrough GIF referenced from your README.md. Please use RecordIt or LICEcap to record an animated GIF of your submission going through the required stories, and include it in your README.md.
I couldn't find a Heroku deploy link listed in your README.md. Please note the URL where you have deployed your app.

chug2k commented 8 years ago

Sorry I forced the issue, he wasn't ready with his GIF yet. He deployed to a non-heroku, at submit.vanhensy.com ;)

hoksilato commented 8 years ago

Hi @vanhensy

Thanks for your submitting. Good work :thumbsup:.

In summary, your submission is good. Great UI/UX. Could you please fix below errors:

The required searching feature?
When deleting stories, show an alert that asks the user to confirm.
Your navbar is not responsive with mobile.

And below are some suggestions that can improve your blog:

For the better performance and UX, you can use kaminari gem for pagination.
Always be cautious with user input, you can use Active Record Validations to validate.
You should not allow user to update/delete the article about yourself.
You should add link to homepage on your logo (TeachMe).

Let us know if you have any questions.

/cc @coderschoolreview @harley

harley commented 8 years ago

Hi @vanhensy have you got the chance to update your code? We have a lot of good submissions. Yours has a lot of potential, but I'd like to see you complete all the required user stories and if you can, at least one optional one. Feel free to message me if you have any questions. /cc @coderschoolreview

vanhensy commented 8 years ago

Hi @chug2k @harley @hoksilato @coderschoolreview ! Sorry for late update. I have many things to do and now I'm gladly to announce that I've fixed it and adding more feature. Could you guys please take a look and give me an other review ?! This is live link: http://submit.vanhensy.com/ The account to login as admin is: username: review@coderschool password: coderschool

Thanks for your time ! Hope to get feedback from you.

hoksilato commented 8 years ago

@vanhensy

Wow, what a huge update, thanks for you hard work. Your UI is really impressive. I love the animation part :100:

There are still some need improvement but let them pass now. We will talk more in class.

Welcome to Ruby course :+1:

/cc @coderschoolreview @harley @chug2k