vanilla-music / vanilla-music-tag-editor

Vanilla Music player Tag Editor plugin
GNU General Public License v3.0
13 stars 6 forks source link

Releasing APKs with each commit #5

Closed dudedaoud closed 7 years ago

dudedaoud commented 7 years ago

Plugins dont work for me. When i press plugins nothings append. And i think i need root to write tag on sd card ? Or need tout have access to sdcard.... Good job dev' thx. Android 5.0 Alcatel Idol 3s

Kaned1as commented 7 years ago

No, you don't need root to write to sdcard.

What versions of vanilla and plugins are you using?

dudedaoud commented 7 years ago

Hi,

I have 1.0.49 for Vanilla music and 1.0.3 to vanilla tag editor. 1.0.1 for Vanilla cover fetcher.

I have plugins to the menu but nothing when i clic on.

2017-02-10 8:56 GMT+01:00 Antic1tizen One notifications@github.com:

No, you don't need root to write to sdcard.

What versions of vanilla and plugins are you using?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vanilla-music/vanilla-music-tag-editor/issues/5#issuecomment-278880503, or mute the thread https://github.com/notifications/unsubscribe-auth/ABw9nsvKnC36sgUOjkUh-qpBs51O9taoks5rbBgTgaJpZM4L9CbN .

Kaned1as commented 7 years ago

Are you using Vanilla Nightly?

Kaned1as commented 7 years ago

@dudedaoud , hey, are you reading?

dudedaoud commented 7 years ago

Yes. Sorry. I dont test the nicht ly built. I test. Thx

Le 18 févr. 2017 18:47, "Antic1tizen One" notifications@github.com a écrit :

@dudedaoud https://github.com/dudedaoud , hey, are you reading?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vanilla-music/vanilla-music-tag-editor/issues/5#issuecomment-280862242, or mute the thread https://github.com/notifications/unsubscribe-auth/ABw9niyf7AWgvtC1-9OCQRIarJ8OjADvks5rdy7AgaJpZM4L9CbN .

rancidfrog commented 7 years ago

Tested latest nightly and plugins appear but clicking it does nothing.

Why does plugins appear in menu and not "Edit Tags"?

Kaned1as commented 7 years ago

Because this kind of change was rejected by Adrian Ulrich, the maintainer of Vanilla Music

rancidfrog commented 7 years ago

Ah okay. Either way, when clicking plugins nothing happened.

rancidfrog commented 7 years ago

https://github.com/vanilla-music/vanilla-music-tag-editor/commit/24ba4c5727dd3148e3aecd5731df2b6f21f6798e Is the issue resolved?

https://github.com/vanilla-music/vanilla-music-tag-editor/releases/tag/1.0.2 Updated release with apk possible? https://github.com/vanilla-music/vanilla-music-tag-editor/releases/tag/1.1.2

Kaned1as commented 7 years ago

Can you fetch one from F-Droid? I believe they rebuild their apks after tag is pushed

rancidfrog commented 7 years ago

Latest version 1.1.2 which has commit is not on f-droid, only 1.1.1 is.

rancidfrog commented 7 years ago

Both

Kaned1as commented 7 years ago

Is it possible to include apk with each release?

Certainly, I just have to make Travis integration work.

Kaned1as commented 7 years ago

Done, each tag pushed into repo triggers a Travis job that compiles the APK and attaches it to Releases page