Close button (X) not visible in notification when using Android 10 Dark theme

[CaviaPorcellus]

• Vanilla Music Version (Settings -> About): 1.0.84
• Android Version: 10
• Phone vendor / model: Google Pixel 3
• Application was downloaded from (use [x]):
  • [ ] Play Store
  • [X] F-Droid
  • [ ] Other (Nightly Build)
• Did this work in a previous version?
  • [ ] Yes
  • [ ] No
  • [X] NA / Don't know.

Description

When Android 10 is set to use the built-in Dark theme, notifications are displayed in black. While Vanilla Music's back/play/forward controls are still visible, the X button used to close the notification is not. It is still there, and it does work if you touch it, but since it is black it is invisible.

There has been an official dark theme since Android 9, but in Android 10 the notifications were changed to be black. I saw that there was some talk about dark theme notifications, but only with regards to custom themes. This is a report to get the notifications looking correct with the default stock Android dark theme.

Steps to reproduce the issue

Using stock Android 10, turn on Dark theme (Settings -> Display -> Dark theme). Play something with Vanilla Music. Gaze upon the notification.

Screenshots

Notification with Dark theme enabled:

Non-dark theme notification for comparison:

[adrian-bl]

Turns out we used transparency in the 'X' image.

I changed the image to not use any alpha channels and add a white border around it in commit https://github.com/vanilla-music/vanilla/commit/497af31e52b3f0dd1c9409b1f196fa486215437c - could you check the latest nightly build to see if things are better?

[CaviaPorcellus]

Sorry for not responding sooner! I actually can't test the nightly build: when I download the apk it just gives me the word "error" when I try to install it.

[adrian-bl]

Interesting: maybe there was something wrong with the build: could you try again? (the APK should get refreshed every 24 hours)

[beerisgood]

@adrian-bl Can you maybe push that as beta to F-Droid?

Then I can test it

[p3732]

The new icon works, but I looks a bit odd:

Why not implement the same solution as for the other buttons? Or are they defined by the OS?

[CaviaPorcellus]

Yep, same here: the X icon is now visible and works, but it seems to be outlined so that it's darker on the inside. Doesn't seem to match any other icons.