search

vanilla-music / vanilla

Vanilla Music Player for Android
GNU General Public License v3.0
1.19k stars 296 forks source link

Plugin system rework v2 #1093

Open Kaned1as opened 3 years ago

Kaned1as commented 3 years ago

Hi @adrian-bl , not sure if you're aware but Google is gradually phasing out non-SAF storage support in apps.

I'm planning a plugin system rework, which will happen in several stages.

  1. I prepare a patch for Vanilla Music to pass files as fds instead of file paths.
  2. I update plugins so that they work with both current and future implementation.
  3. I create PR for Vanilla Music to change the default behaviour to SAF-compliant.

Main questions from me, before I start: Are you still maintaining Vanilla Music? Are plugin-related contributions still welcome?

adrian-bl commented 3 years ago

Hi @Kaned1as

Yes, i'm still maintaining the app (but don't invest too much time lately) and would welcome plugin related contributions.

Note that we currently rely on the fact that SDK30 gives you read-only access to media files without using SAF (See https://medium.com/androiddevelopers/android-11-storage-faq-78cefea52b7c) and i don't plan to generally use it in Vanilla itself - unless we absolutely have to for some use case.

(Right now, deleting files is broken since SDK30 only grants read-only access. We likely need to use SAF for these permissions - but for general media playback and indexing it is not needed)

Kaned1as commented 3 years ago

Understood, will start preparing patches then.

Thanks for keeping it alive by the way.