vanilla-music / vanilla

Vanilla Music Player for Android
GNU General Public License v3.0
1.18k stars 295 forks source link

Sort by Year results are out of chronological order #1099

Open ghost opened 3 years ago

ghost commented 3 years ago

Description

When using Sort by Year, albums of the same year but different date are sorted out of chronological order, even when they have valid YYYY-MM-DD tags.

I already have 17 albums from 2021. I have 23 albums from 2020. It's a mess. It's really apparent when I add a brand new album that was just released, and (with Sort by Year Reverse), it doesn't appear on top as it should.

I don't know how it is sorting albums of the same year. It appears arbitrary. When the sort is reversed or unreversed, that arbitrary order does not flip around.

Also, I noticed that when viewing the mp3 tag details in Vanilla Player, it only shows the year even when the mp3 is tagged with a full date. ....

Steps to reproduce the issue

Sort by Year with two or more albums of the same year and valid YYYY-MM-DD in the tag. Reverse the sort, and check whether the order reversed. ...

Screenshot / Video (If applicable)

Not applicable. ...

This is a re-write of #1058 to clarify the issue and call attention to it.

Where is the code that sorts by year?

Can the code be updated without integrating a new mp3 tag reader? I mean, is the issue due to a tag reader not getting the full date, or does the app have access to the full date but isn't using it?

ghost commented 3 years ago

apparently this line is used to strip month and day

https://github.com/vanilla-music/vanilla/blob/aedd1f2daeab392dacc7241df4e17234c8d77513/app/src/main/java/ch/blinkenlights/android/medialibrary/MediaMetadataExtractor.java#L51