search

vanilla-music / vanilla

Vanilla Music Player for Android
GNU General Public License v3.0
1.19k stars 296 forks source link

Can't delete any file from vanilla #1134

Open granvaud opened 2 years ago

granvaud commented 2 years ago

Description

I have a failure message when I try to delete a file and I don't know what to do... ....

Steps to reproduce the issue

...

Screenshot / Video (If applicable)

...

luuuciano commented 2 years ago

Maybe I have this issue too? I am using lineageOS 18.1 I have applied the file permission access... so files are listed, I can listen, etc... BUT when I try to delete a file it just shows "0 tracks deleted"...

Any idea? What to do? What to check?

Deleting files I do not like was a very used feature here... D-:

jadeops commented 1 year ago

Same here. Delete is not fixed in v1.2.2 released recently :(

Cwpute commented 1 year ago

It's not a Lineage OS problem as i'm wn Android 11 with a Nokia TA-1157, and i huve the same problem as well.

andiandi13 commented 1 year ago

I think it was discussed here #691 Files from internal storage can be deleted, by not from SD Card since Vanilla doesn't have permissions

luuuciano commented 1 year ago

Mmmm maybe, but I do not think so... I have no SD card, is the regular internal storage And I remember Vanilla asking for access to it (it give it), there is no error showed when trying to delete a song, it just does nothing

jadeops commented 1 year ago

Same here. No SD Card. Oneplus 6. Internal Storage music files can be played but not deleted. I think it broke after Android 10/11 update. Most probably related to the new "Scoped Storage" https://www.geeksforgeeks.org/scoped-storage-in-android/ Other music players have added support for it, vanilla has not added it yet :(

Cwpute commented 1 year ago

Maybe we can try to see how other music players implemented that feature/corrected that bug, and see if any of their method could fit into how Vanilla works. There are plenty other players on Fdroid store to choose from: Screenshot_20230107-201737 I don't personally have the knowledge for it , but maybe someone here has?

andiandi13 commented 1 year ago

Interesting, so it's an SDCard access issue. I'm in Android 9 so maybe there's an issue with further versions.

OxygenCobalt commented 1 year ago

Developer of Auxio here. Since Android 10 trying to do something as basic as modify files has grown so exponentially complicated and bug-filled as to basically be impossible. Without access to File, you have to use MediaStore, which has notoriously broken SD Card support. The only way to get around this is either to obtain the extremely dangerous MANAGE_EXTERNAL_STORAGE permission (See: Material Files) or stay on API 29 forever.

Repeated attempts to report this issue have been closed by google with the reasoning that it's "Working as Intended". This makes no sense until you realize that google hates the filesystem and deliberately crippling functionality like this furthers their quest to turn Android into an iOS-like data funnel where you can't listen to music that you own.

This is personally why I do not implement song deletion in my app. You basically cannot implement it in any reasonable capacity on modern android. You're generally better of removing the ability entirely and recommending the use of a file manager instead.

luuuciano commented 1 year ago

The regular phone storage is taken as an external SD card too? Because I do not have the files in a SD card... Currently I am using "Music Player" 0.9.6 and I can delete files using it...

OxygenCobalt commented 1 year ago

The regular phone storage is taken as an external SD card too? Because I do not have the files in a SD card...

No. Most phone storage is considered "internal" and doesn't really suffer from this issue.