Revisit ReplayGain volume over 1? - Githubissues

vanilla-music / vanilla

Vanilla Music Player for Android

GNU General Public License v3.0

1.19k stars 296 forks source link

Revisit ReplayGain volume over 1? #1197

Open dseomn opened 9 months ago

dseomn commented 9 months ago

Vanilla Music Version (Settings -> About): 1.3.2
Android Version: Android 13, LineageOS 20
Phone vendor / model: Moto G7 Plus
Application was downloaded from (use [x]):
- [ ] Play Store
- [x] F-Droid
- [ ] Other (Nightly Build)
Did this work in a previous version?
- [ ] Yes
- [x] No
- [ ] NA / Don't know.

Description

I think there have been some relevant changes to Android's APIs since #178. https://github.com/google/ExoPlayer/issues/3657#issuecomment-354961395 mentions AudioProcessor as a potential option, and https://developer.android.com/reference/androidx/media3/common/audio/ChannelMixingAudioProcessor looks like it might work. I'm not familiar with that API, but do you think it's worth revisiting the issue?

Steps to reproduce the issue

N/A

Screenshot / Video (If applicable)

N/A