vanilla-music / vanilla

Vanilla Music Player for Android
GNU General Public License v3.0
1.15k stars 291 forks source link

Support of additional tags and filtering by folder/category #478

Open apikozh opened 7 years ago

apikozh commented 7 years ago

Hello All! I searched for opensource music player with advanced playback queue, playlists, ability to sort media by tags (title, artist, track#, BPM, etc), and i found the vanilla-music project. I started using it some weeks ago and it's pretty cool!

  1. I see that you implements your own MediaDB and tags reader. It would be great to implement support for BPM, comment, lyrics tags where it is possible. Especially BPM. The ability to sort songs by BPM.

  2. I have a fairly large collection of music of different genres and for different situations. I divide it into category folders (eg, Metal, Jazz, Rock & Roll, My mixes, Work records). This is not the playlists - music is not duplicated in these categories. The problem is that all music players collects all the music in one heap without regard categories. At first time, I solved this problem by creating playlists for each category, but it deprive me of the opportunity to enjoy the comforts of the player (albums, genres, artists, sorting and searching) for each category. I propose to add the ability to filter albums, songs, artists and genres by category (folder) as follows: user open the files tab, selects the desired folder with music, opens a context menu with long press and selects "Show songs only from this folder" and then Limiter with the name of the folder is added to all tabs, as you have been implemented with the artists, albums and genres.

  3. I think, most users do not need all the audio files from the device. They store all music files in a separate folder (often, folder "Music" on SD card or internal memory). I propose add ability to select folder (s) to scan the music in settings. After folder is specified, the files tab location set to this folder by default.

adrian-bl commented 7 years ago

I see that you implements your own MediaDB and tags reader. It would be great to implement support for BPM, comment, lyrics tags where it is possible. Especially BPM. The ability to sort songs by BPM.

We could add it at least for ogg and vorbis files (where we are using bastp to parse tags - androids metadata reader which is used for everything else does not return this information). But i would like to keep the songs table small and not clutter it with seldomly used information - but if there is demand, it's doable.

and then Limiter with the name of the folder is added to all tabs, as you have been implemented with the artists, albums and genres.

So how would work this with eg. artists? We would only show artists which are in this folder?

I propose add ability to select folder (s) to scan the music in settings. After folder is specified, the files tab location set to this folder by default.

Giving the user the ability to pick folders to include in the library is on my todo list for the medialibrary. (But the UI for it will probably not be included in the first 'medialibrary-based' relase)

apikozh commented 7 years ago

@adrian-bl

We could add it at least for ogg and vorbis files

As I know, ID3v2 also supports these tags. Therefore, for MP3 it is also possible to be realized.

But i would like to keep the songs table small and not clutter it with seldomly used information

Comment and lyrics info can be loaded dynamically from file, when requested by user. There is no need to store this information in a table.

but if there is demand, it's doable.

I saw on the Internet a few topics that discuss music players for Android with support for viewing and sorting songs by BPM. In addition, I have many friends who are interested in this functionality (mostly dance teachers or people who practice dance or play sports). I think it would be a great feature of this player.

So how would work this with eg. artists? We would only show artists which are in this folder?

Yes exactly. Same with albums, genres and songs.