search

vanilla-music / vanilla

Vanilla Music Player for Android
GNU General Public License v3.0
1.18k stars 295 forks source link

Album view sort "By Title" broken, makes two separate alphabetical #897

Closed ghost closed 5 years ago

ghost commented 5 years ago

Album view's sorting "By Title" is broken for me since recently (a month or so), it makes two separate alphabetical lists with a certain whatever subset A-Z first, then it jumps back to A and has another long list A-Z. This is pretty inconvenient because now I always need to look in two places to find something. This started to happen when I scanned for new media at some point with the new media suddenly forming on top as separate list, but even "Flush media database" hasn't ever fixed this and the second list only has started to grow longer.

Steps to reproduce the issue

Really not sure, this just randomly started happening at some point when new media was added

adrian-bl commented 5 years ago

Can you go to Settings > Media Library > (menu) > Dump database and upload the file somewhere?

(The file contains the metadata of your media library (tags and playlists)).

Did you change the language on your phone at some point?

ghost commented 5 years ago

@ language: not that I know of, but clearing the app data fixed it. I wonder though, I remember this starting around the time I did a "Flush database" scan, but I recall being surprised that the list of titles wouldn't actually clear out (and starting at roughly that time, new entries would show up separately). Maybe the flushing is broken sometimes and that caused it?

adrian-bl commented 5 years ago

The library is only updated after the scan finished, so it is normal that you'll still see the old database during a flush.

If flushing didn't fix the issue, then this is very likely related to a language change: We should rebuild our sorting-key if this happens.

ghost commented 5 years ago

@adrian-bl the old entries never disappeared though. and I am 99% certain i didn't change the language, I don't even know how to do that

I remember in some older version, the entries disappeared right at the start, which I found more intuitive (also then it's immediately obvious the flushing worked, whereas with the current behavior it kinda leaves you guessing). How about going back to that behavior maybe?

adrian-bl commented 5 years ago

Having the library constantly updating during a scan made it impossible to scroll while the scanner was running on some android versions, so i'd prefer to keep this as it is.

Closing this issue as we don't have a DB dump, but i suppose that it is very similar to #889 (might not have the same root cause, but rebuilding the search index should have also fixed this issue)