Scan changes should flush the LRU cover cache [Was: Embedded cover art isn't updated when rescanning without a clean restart of entire app]

[ghost]

• Vanilla Music Version (Settings -> About): 1.0.81
• Android Version: 7.1.1
• Phone vendor / model: Gemini PDA
• Application was downloaded from (use [x]):
  • [ ] Play Store
  • [X] F-Droid
  • [ ] Other (Nightly Build)
• Did this work in a previous version?
  • [ ] Yes
  • [ ] No
  • [X] NA / Don't know.

Description

Embedded cover art isn't updated when rescanning without a clean restart of entire app.

Steps to reproduce the issue

1. Add a song with no embedded cover (in the id3 tags or anywhere else) & album name
2. Scan such that it shows up in the album list with no cover
3. Change the song's disk file to actually have an embedded cover into its id3 tags, change something else you like (e.g. title)
4. Scan with "Scan full filesystem (slower)" enabled

--> all the other info like album name & title updates, but the album is still shown with no cover

5. Restart app (by stopping playback, stopping scanning, then going into the recent app/task manager overview and clicking the small "Close" button)
6. Relaunch vanilla
7. Observe that now, the cover is actually updated - without any further change (like an additional rescan or anything)

[andiandi13]

I think your issue is kinda a duplicate of #662.

It would be cool to be able to clear cover cache without having to flush the entire library !

[ghost]

@andiandi13 there is still a difference between "I want a button to separately force the covers to update at any time I like" (which is #662 ) and the question whether I should need to do this in the first place, which I think for a rescan I shouldn't! If Vanilla detects a change in the file, why can it not automatically also attempt to update the cover? That would make much more sense to me

[adrian-bl]

What you see is the LRU cover cache.

I guess we really should flush it if the media scanner noticed changes. (changing the title)