search

vanilla / addons

Official add-ons and tools for Vanilla Forums.
http://open.vanillaforums.com
108 stars 169 forks source link

Fix admins able to spoof system user #805

Closed blutarch closed 4 years ago

blutarch commented 4 years ago

Closes vanilla/support#1869

An admin user is able to spoof in as the system user. This is undesirable because they can then see themes and plugins we may not want them to. This adds a check before displaying the spoof button and prevents it from being displayed for system users.

TO TEST

  1. As an admin, go to dashboard/user
  2. Verify that no system users have spoof buttons.
danni-stark commented 4 years ago

You'll need to assign someone for review @blutarch