vanilla / wordpress-vanilla

Official WordPress plugin for Vanilla Forums integration.
https://open.vanillaforums.com
GNU Lesser General Public License v3.0
17 stars 6 forks source link

REST routes updates and Https support for validation #11

Closed MikhailRoot closed 8 years ago

MikhailRoot commented 8 years ago

+Webroot parsing fix

linc commented 8 years ago

You haven't synced to current master, so you are double-adding the webroot fix and it's conflicting. Also, see my comments on the other PR. And please be sure to give a descriptive title, not "Fixes".

MikhailRoot commented 8 years ago

ok i need to make a new pull request with routes done in more universal way without /api/ ?

MikhailRoot commented 8 years ago

I've checked all changes again, and all seems ok. Also updated Pull request title to make it more informative.

MikhailRoot commented 8 years ago

Sorry i'm a bit newbie with some of git features. I've merged webroot fix in mine so now as i see it could be merged successfully. Also added accidentally removed .json ending in route what you've mentioned above.

linc commented 8 years ago

Thanks! Good catch on the root problem too, I didn't realize we were still using the p param over here.