vanillaes / jqkill

Locate all references to jQuery for easy removal
MIT License
7 stars 1 forks source link

Remove false positives #2

Open evanplaice opened 4 years ago

evanplaice commented 4 years ago

The parser needs to be updated and tests need to be added to ensure that no false positives are included in the output.

Changes

Note: The tests should be added to jqkill.spec.js, fixtures should be named with the pattern false[n].js

False positives include

1 Minifiers do a lot of weird stuff that may look like jQuery. Exclusion via the ignore option may be the only fix

itaditya commented 4 years ago

Also template literals

${}

evanplaice commented 4 years ago

Good catch

evanplaice commented 4 years ago

@itaditya Do you want to work on this issue?