search

vanilophp / demo

Vanilo Demo Application
https://vanilo.io/docs/
190 stars 54 forks source link

Product Image Won't Show #17

Closed joeprabawa closed 5 years ago

joeprabawa commented 5 years ago

Hi, i got this issue after upload the product image. I've opened up the console and it showing this error message : GET http://127.0.0.1:8000/storage/2/conversions/01-thumbnail.jpg 404 (Not Found)

screencapture-localhost-8000-admin-product-2019-01-01-18_58_28

The preview image didn't showed up, both from the admin panel and from the client Need a guide to fix this problem. Thank you so much in advance :)

fulopattila122 commented 5 years ago

You have to run php artisan storage:link

https://laravel.com/docs/5.7/filesystem#the-public-disk

fulopattila122 commented 5 years ago

Did it solve the problem?

cfrisly commented 5 years ago

I also have a similar problem with the images does not show them in admin and the store if I have the storage folder

fulopattila122 commented 5 years ago

@cfrisly Did you try php artisan storage:link?

joeprabawa commented 5 years ago

halo @fulopattila122, i already did the command. it said The "public/storage" directory already exists

fulopattila122 commented 5 years ago

Generally it's not a Vanilo but a filesystem/permission problem, but I'll try to help. What answer do you get when you right click the broken image and click open in new tab? Is it 404 or 403? What do you see in your log files at the same time? How do you run your web server, via php artisan serve or via nginx or apache maybe homestead or docker? Does the user running the web server have permission to read from those folders? Does the problem apply to newly uploaded images as well or only to those previously uploaded?

joeprabawa commented 5 years ago

@fulopattila122 thank you so much for the help.

  1. it's 404 with this url http://127.0.0.1:8000/storage/3/01.jpg
  2. On the console it says GET http://127.0.0.1:8000/storage/3/conversions/01-thumbnail.jpg 404 (Not Found) 3 & 4. I use php artisan serve with basic phpmyadmin root config
  3. Applied to all images
fulopattila122 commented 5 years ago

What's the output of

stat public/storage

?

Btw what OS are you using?

joeprabawa commented 5 years ago

screenshot_1

I got that, i'm using windows 7

fulopattila122 commented 5 years ago

Windows 😶

The problem is that Laravel saves the file into storage/app/framework/public, whereas public/storage should be a symlink to ../storage/app/public but as far as I see it's a regular file.

It should be like this:

fulop@asus-UX303LA î‚° vanilo/demo î‚° î‚  master î‚° stat public/storage 
  File: public/storage -> ../storage/app/public
  Size: 21          Blocks: 0          IO Block: 4096   symbolic link
Device: 802h/2050d  Inode: 7082242     Links: 1
Access: (0777/lrwxrwxrwx)  Uid: ( 1000/   fulop)   Gid: ( 1000/   fulop)
Access: 2019-01-03 12:20:50.283873521 +0100
Modify: 2018-06-26 22:07:59.484280669 +0200
Change: 2018-06-26 22:07:59.484280669 +0200
 Birth: -

Windows symlinks are out of my expertise, so I suggest to take a look at these issues: https://github.com/laravel/framework/issues/15439 https://github.com/spatie/laravel-medialibrary/issues/1275

fulopattila122 commented 5 years ago

:bulb: my last tip: you may try to delete public/storage (only if it's empty) and run php artisan storage:link again.

joeprabawa commented 5 years ago

Thanks for refrenced the issue on the spatie @fulopattila122, i red the comments there, and yes ! i already did your method a moment ago, it works ! :smile:

thank you so much for your help !!! Vanilo Rocks

fulopattila122 commented 5 years ago

Cool to hear! rock&roll ;) 🤘

allawliet commented 5 years ago

Hye, i have tried delete the storage and run the command again but still not working..can someone help me..

fulopattila122 commented 5 years ago

@allawliet What's the output of

stat public/storage

?

What OS are you using?

allawliet commented 5 years ago

it show the same as you show

my

allawliet commented 5 years ago

and i am windows hahaha

fulopattila122 commented 5 years ago

What does the Browser give you when you try to open the image directly? (Right click the broken image and "Open Image in new Tab") 404 or 403, or ...? Also what do you see in your logs?

allawliet commented 5 years ago

the error is 404 and there is nothing in my logs my2

fulopattila122 commented 5 years ago

What is the URL of the broken image?

allawliet commented 5 years ago

http://localhost/storage/6/conversions/B37705_01-thumbnail.jpg

allawliet commented 5 years ago

Hye...i got it..i change the APP_URL and thank god its working =) Thank you for your help !!

fulopattila122 commented 5 years ago

Exactly :)

Niz47 commented 4 years ago

Hye...i got it..i change the APP_URL and thank god its working =) Thank you for your help !!

Hey man, you saved my time. Thanks a million :)