search

vanilophp / docs

Vanilo Documentation (Laravel E-commerce)
https://vanilo.io/docs/
6 stars 9 forks source link

Add MariaDB to possible database engine #2

Closed frezno closed 5 years ago

frezno commented 5 years ago

The JSON alias was added in MariaDB v10.2.7. https://mariadb.com/kb/en/library/json-data-type/

fulopattila122 commented 5 years ago

Thanks for this PR!

Are you sure that it works properly?

As far as I see in MariaDB json field type is an alias to longtext thus I think not all the MySQL/Postgres JSON functions work there.

I prefer to run a test with the mentioned version of MariaDB to see if Spatie Media Library actually works properly with it.

frezno commented 5 years ago

Didn't test out everything yet. Should have done it before PRing, just to make 100% sure.

fulopattila122 commented 5 years ago

No problem at all, I'm really happy that you've let me know the fact of MariaDB json fields. If you have no time I'll make a test until mid-week and come back here to discuss.

fulopattila122 commented 5 years ago

I ran a test against MariaDB 10.2.19 and it works 👌

Thank you!

frezno commented 5 years ago

cool