Issues running yarn run dev

joaogl commented 5 years ago

Hello,

After installation following the documentation the following error showed up upon running yarn run dev:

ERROR in ./vendor/konekt/appshell/src/resources/assets/sass/appshell.sass
Module build failed (from ./node_modules/css-loader/index.js):
ModuleBuildError: Module build failed (from ./node_modules/sass-loader/lib/loader.js):

  &.callout-#{$color} {
 ^
      Top-level selectors may not contain the parent selector "&".
  &.callout-#{$color} {
  ^^^^^^^^^^^^^^^^^^^^
  vendor/konekt/appshell/src/resources/assets/sass/core/_callout.scss 48:3  @import
  stdin 45:9                                                                root stylesheet

My versions are the following:

vagrant@homestead:~/code/vanillo$ composer show konekt/appshell|grep 'versions'
versions : * 1.3.0
vagrant@homestead:~/code/vanillo$ composer show vanilo/framework|grep 'versions'
versions : * 0.4.0
vagrant@homestead:~/code/vanillo$ composer show laravel/framework|grep 'versions'
versions : * v5.7.20

In the mean time I'm going to use your demo repo to run a few tests.

Also, I'm going to be building an e-commerce site for the next 2 months at least with a lot of free time. I'm interested in a few features that you still have in development/not release so if you need help on those I would gladly help you and this framework while doing also my website.

Thanks, João Lourenço.

fulopattila122 commented 5 years ago

Thanks for the report!

What's on the 47th line of vendor/konekt/appshell/src/resources/assets/sass/core/_callout.scss ? It should be exactly like that: https://github.com/artkonekt/appshell/blob/1.3.0/src/resources/assets/sass/core/_callout.scss#L47

mzelenkin commented 5 years ago

I have the same problem.

versions : * 1.3.0
composer show vanilo/framework|grep 'versions'
versions : * 0.4.0
composer show laravel/framework|grep 'versions'
versions : * v5.7.21

Line 47 is the same as the link

fulopattila122 commented 5 years ago

Looks like we're hitting the very same problem here: https://github.com/BRACKETS-by-TRIAD/craftable/issues/69

andreud commented 5 years ago

a quick solution is to remove the "&" in &.callout-#{$color} { from line 48 of vendor/konekt/appshell/src/resources/assets/sass/core/_callout.scss

fulopattila122 commented 5 years ago

The issue in the underlying AppShell component has been resolved. You need at least AppShell v1.3.1 to have yarn running again.. Run composer update konekt/appshell to get the latest version. I'll also bump to v1.3.1 as a minimum requirement for upcoming Vanilo Framework releases.

vanilophp / framework

Issues running yarn run dev #30