search

vanilophp / framework

The truly Laravel E-commerce Framework
https://vanilo.io
MIT License
818 stars 102 forks source link

Laravel 5.8 support #36

Closed jhm-ciberman closed 5 years ago

jhm-ciberman commented 5 years ago

Hello. It seems Vanilo does not support Laravel 5.8 (released today). Can you update the composer.json?

I am in hurry because I need to start a project for a client this week. Thanks a lot!

jhm-ciberman commented 5 years ago

It seems the problem is with spatie/laravel-medialibrary

jhm-ciberman commented 5 years ago

I have created an issue https://github.com/spatie/laravel-medialibrary/issues/1398

fulopattila122 commented 5 years ago

Providing Laravel 5.8 compatibility in such libraries is not only updating composer.json, but also making sure unit and integration tests pass and to resolve compatibility issues.

Vanilo framework along with the modules has composer settings that allow any 5.x version of Laravel.

I label Vanilo releases as "Laravel X" compatible after the compatibility is proven. Expect it within the next few days.

jhm-ciberman commented 5 years ago

Hello. There is already a new release for ´spatie/laravel-medialibrary´. But konekt/AppShell does not support it yet. So I will use L5.7 and wait meanwhile. Thanks :)

fulopattila122 commented 5 years ago

This issue is high prio on my table, so hold on ;)

kkrieger85 commented 5 years ago

@fulopattila122 Is it possible to add laravel/framework to composer.json to speficy dependencies?

fulopattila122 commented 5 years ago

Laravel 5.8 compatibility has been fully fixed in Vanilo v0.5.1. New installations will work from now on.

To fix an existing installation, run:

composer update 'vanilo/*' konekt/menu konekt/appshell
fulopattila122 commented 5 years ago

@kkrieger85 laravel/framework has been explicitly added to composer.json