search

vanilophp / framework

The truly Laravel E-commerce Framework
https://vanilo.io
MIT License
818 stars 102 forks source link

Missing dependencies in packages.json #65

Closed mwkcoding closed 4 years ago

mwkcoding commented 4 years ago

I ran npm run dev after npm install and the output was the following

These dependencies were not found:

* popper.js in ./vendor/konekt/appshell/src/resources/assets/js/appshell.standalone.js
* vue in ./vendor/konekt/appshell/src/resources/assets/js/appshell.standalone.js

To install them, you can run: npm install --save popper.js vue
            Asset     Size        Chunks             Chunk Names
     /css/app.css  0 bytes       /js/app  [emitted]  /js/app
/css/appshell.css  264 KiB       /js/app  [emitted]  /js/app
       /js/app.js  593 KiB       /js/app  [emitted]  /js/app
  /js/appshell.js  594 KiB  /js/appshell  [emitted]  /js/appshell

WARNING in ./vendor/konekt/appshell/src/resources/assets/js/appshell.standalone.js
Module not found: Error: Can't resolve 'bootstrap' in '/Users/mwkcoding/Code/vanilo/vendor/konekt/appshell/src/resources/assets/js'
 @ ./vendor/konekt/appshell/src/resources/assets/js/appshell.standalone.js
 @ multi ./vendor/konekt/appshell/src/resources/assets/js/appshell.standalone.js

WARNING in ./vendor/konekt/appshell/src/resources/assets/js/appshell.standalone.js
Module not found: Error: Can't resolve 'jquery' in '/Users/mwkcoding/Code/vanilo/vendor/konekt/appshell/src/resources/assets/js'
 @ ./vendor/konekt/appshell/src/resources/assets/js/appshell.standalone.js
 @ multi ./vendor/konekt/appshell/src/resources/assets/js/appshell.standalone.js

ERROR in ./vendor/konekt/appshell/src/resources/assets/js/appshell.standalone.js
Module not found: Error: Can't resolve 'popper.js' in '/Users/mwkcoding/Code/vanilo/vendor/konekt/appshell/src/resources/assets/js'
 @ ./vendor/konekt/appshell/src/resources/assets/js/appshell.standalone.js 2:16-36
 @ multi ./vendor/konekt/appshell/src/resources/assets/js/appshell.standalone.js

ERROR in ./vendor/konekt/appshell/src/resources/assets/js/appshell.standalone.js
Module not found: Error: Can't resolve 'vue' in '/Users/mwkcoding/Code/vanilo/vendor/konekt/appshell/src/resources/assets/js'
 @ ./vendor/konekt/appshell/src/resources/assets/js/appshell.standalone.js 37:13-27
 @ multi ./vendor/konekt/appshell/src/resources/assets/js/appshell.standalone.js

I add these to the package.json manually and no problems occour. This should not be a thing.

fulopattila122 commented 4 years ago

Thanks for the report. It's caused by Github's auto security patches that were complaining about some outdated packages having security issues. Looks the auto fix didn't work impeccably.

Could you please tell me which packages did you add to fix the errors?

mwkcoding commented 4 years ago

I added the packages it was saying were missing, ran npm run dev again, worked. So jquery, vue, popper.js

Those were the ones I added.