vanilophp / paypal

PayPal Module for Vanilo Payments
MIT License
1 stars 2 forks source link

Cancel Method Issue at the PaypalReturnController #3

Open fulopattila122 opened 3 years ago

fulopattila122 commented 3 years ago

@fulopattila122 I have detected another issue with the cancel method, at the PaypalReturnController. Should I open another PR to discuss the issue, or should I wait?

Thank you by the way for the vanilo framework!

Originally posted by @damarev in https://github.com/vanilophp/paypal/issues/2#issuecomment-798896058

fulopattila122 commented 3 years ago

@kedves could you please check this one? thx!

damarev commented 3 years ago

The problem I have detected is, the generated return url from paypal currently doesnt have the paymentId as parameter.

fulopattila122 commented 3 years ago

You need to pass a unique return url to PayPal that contains the payment I'd, so that you can look it up on return

damarev commented 3 years ago

Sorry, the return success url does have the paymentId parameter, its in the cancel url that is missing.