vanilophp / product

Product Module for Vanilo (or any Laravel app)
https://vanilo.io
MIT License
18 stars 8 forks source link

Changed 'stock' column type from decimal to unsigned medium integer #10

Closed yoeriboven closed 4 years ago

yoeriboven commented 4 years ago

Fixes #9

fulopattila122 commented 4 years ago

Thanks for the PR.

On the other hand we never change existing migrations, but would add a new one to change an existing column. It is a breaking change thus it would also require a bump of a major version.

You can add this migration to your project that you're building on top of this module and convert the field to integer locally. As you see it's highly unlikely that this field will be changed later in the framework.

We've created the modules/framework in a way that you can easily customize it. Thus we accept PRs that are serving the generic nature and not the specifics, like this one.