search

vanjs-org / van

🍦 VanJS: World's smallest reactive UI framework. Incredibly Powerful, Insanely Small - Everyone can build a useful UI app in an hour.
https://vanjs.org
MIT License
3.87k stars 91 forks source link

Adding TypeScript support VanCone #189

Open yahia-berashish opened 10 months ago

yahia-berashish commented 10 months ago

Hello again. I will be trying to open a PR to add TypeScript support, but I don't have enough information about how the vanjs-core works, I tried to get some things done with ChatGPT, but I think I still need help from @b-rad-c on how the code functions and what types are expected to be passed and result from the code.

b-rad-c commented 10 months ago

Awesome thanks! Could you close the pull request on this repository and open a PR on the ts-support branch of my repository?

I just pushed a new version last night that has contribution instructions in the README. I'm maintaining the project but it's hosted in the official VanJS repo which I don't have write permissions to. So the procedure is to open a PR on my repository, I'll approve/merge and then make a pull request upstream to the official VanJS repo.

The new version has some additional features/changes so we'll need to address that in your new ts file, if you have time to update it that'd be great, if not just push what you have right now and I'll update it. The changes are noted in the changelog in the readme file.

Thanks a lot for your help!