vankop / jsoneditor-react

react wrapper implementation for https://github.com/josdejong/jsoneditor
MIT License
265 stars 106 forks source link

add PropType.array for value property to eliminate warnings #11

Closed iamnotstone closed 5 years ago

iamnotstone commented 5 years ago

to eliminate warning when give array type of value to Editor.

vankop commented 5 years ago

Hi! Thanks for your PR!

Could you remove jsoneditor as a dependency please, jsoneditor-react is assuming jsoneditor is installed as peer dependency, see https://github.com/vankop/jsoneditor-react/blob/master/package.json#L76

iamnotstone commented 5 years ago

ok, jsoneditor removed now

vankop commented 5 years ago

@iamnotstone merged. I have published version 1.0.1, so you can check it =)