vanlummelhuizen / ASL-ELAN

2 stars 0 forks source link

Add menu item on gloss: 'Show in Signbank' #9

Closed ocrasborn closed 7 years ago

ocrasborn commented 8 years ago
screenshot 2016-03-05 12 07 31
vanlummelhuizen commented 8 years ago

Is it possible to have a reference to Signbank in an ECV?

vanlummelhuizen commented 8 years ago

@ocrasborn Alright. I have given it some more thought. Some explanation of my earlier comment: to make this function generic for all future Signbanks, where ever they are hosted, we need some way to determine that an ECV reference is without a doubt a Signbank-ECV reference. We could for now use the heuristic 'is the text "signbank" in the reference url', but it may result in 'page not found's if it is actually not a Signbank. Also, we need a way to determine the path to a gloss, after the host name. Is it always '/dictionary/gloss/'? I will implement a non-future proof version that can be altered when needed.

henrinie commented 8 years ago

@vanlummelhuizen

Is it always '/dictionary/gloss/'?

It might not always be that, but it is always possible to redirect that url to the correct one.

vanlummelhuizen commented 8 years ago

@henrinie Alright, but that implies that the ELAN user will have that power to make that happen somehow. And the path may actually be used for something else. (Perhaps I am too much of a pessimist.) Anyway, since the connection between ELAN and Signbank will be completely different in the hopefully near future, this is not a great concern. The near future involves setting the Signbank url and credentials and downloading all necessary Signbank data on you local disk for ELAN to read. A kind of ECV++.

henrinie commented 8 years ago

@vanlummelhuizen That sounds great. You are not being too pessimistic, if it can fail it will, right? :)

The near future involves setting the Signbank url and credentials and downloading all necessary Signbank data on you local disk for ELAN to read. A kind of ECV++.

Will that support https?

vanlummelhuizen commented 8 years ago

@henrinie From an ELAN point of view, it can be either http or https. We could demand https. From a Signbank point of view I would hope https is at least a possibility. Perhaps @woseseltops can chip in here.

henrinie commented 8 years ago

@vanlummelhuizen I really hope it will be https only. From signbank point of view https definitely is a possibility, the only thing stopping us (FinSL-signbank) from enforcing https only is that I can't get the ECV export to work in ELAN via https.

vanlummelhuizen commented 8 years ago

Ah, good point. I am going to check if https could be added for ECVs.

vanlummelhuizen commented 8 years ago

@ocrasborn This is implemented now. You can download the new jar. A few things are hardcoded:

vanlummelhuizen commented 8 years ago

@henrinie I tested using an ECV over a https connection. It works as it should so there might be a problem with your https connections. You could investigate using these helpful urls: https://www.ssllabs.com/ssltest/analyze.html and http://www.digicert.com/help

I problem I encountered before was a broken certificate chain, which means your specific https certificate does not refer to one of the worlds main certificate authorities.

henrinie commented 8 years ago

Sorry for the off topic in this issue. @vanlummelhuizen Thanks for the tips. I ran those tests: https://www.digicert.com/help/ gives all green, and https://www.ssllabs.com/ssltest/analyze.html grades the cert as A.

It might be that I have some other problem too. ELAN gives me a Warning: Could not read the file:, when I try with the https address instead of the http one (which works). This is with ELAN 4.9.4 on Linux.

If you have a test ecv online behind https I would like to test it if possible.

vanlummelhuizen commented 8 years ago

@henrinie This is interesting: when started from a regular installation, I encounter the problems you describe. But when started from my development environment (Eclipse IDE), there is no problem. I reckon it can be easily fixed, but finding that solution may take a while. Perhaps I contact Han Sloetjes (main devoper of ELAN, Max Planck Institute Nijmegen) about this. I will let you know.

vanlummelhuizen commented 8 years ago

@henrinie Ok, I came this far: starting ELAN from Eclipse or directly from the commandline makes it accept https. When starting from the installation script (InstallAnywhere/LaunchAnywhere) https is not accepted. I think I will mail Han Sloetjes now, since the responsibility for this lies with him. I will let him know that it is like this on Ubuntu. What OS are you using?

henrinie commented 8 years ago

@vanlummelhuizen Thank you for testing this. I am using RHEL 7.2 (Red Hat Enterprise Linux), Kernel 3.10.0-327. I can test it on Fedora linux too if needed. And also on any livecd available.

vanlummelhuizen commented 8 years ago

@henrinie I just tested it on Window 7 and I got the same problem. Han will look into this next week. I will keep you posted.

ocrasborn commented 8 years ago

Tested; works fine.