search

vanna-ai / vanna

🤖 Chat with your SQL database 📊. Accurate Text-to-SQL Generation via LLMs using RAG 🔄.
https://vanna.ai/docs/
MIT License
11.04k stars 862 forks source link

parameterized the number of documentation documents to be retrieved #354

Closed GiacomoPracucci closed 5 months ago

GiacomoPracucci commented 5 months ago

I am working with ChromaDB with many small documentation documents and need to increase the number of retrieved documentation documents from the vectorstore.

it would be useful to also be able to parameterize the number of documentation documents to be retrieved from the vectorstore

fixes #353

andreped commented 5 months ago

@GiacomoPracucci Can you add the "fixes #353" to the PR description. That way when this PR is merged, the issue will automatically be closed.

zainhoda commented 5 months ago

Thanks @GiacomoPracucci !

@andreped I made some changes here -- the parameters are n_results_sql, n_results_documentation, and n_results_sql which if not present, back up to n_results, and then default to 10.

This gives the user the option to granularly set the n_results for each type or to set them all at once or to omit them. WDYT?

andreped commented 5 months ago

@zainhoda LGTM :) Looking forward to testing this on Monday hopefully. Great job!