search

vanna-ai / vanna

🤖 Chat with your SQL database 📊. Accurate Text-to-SQL Generation via LLMs using RAG 🔄.
https://vanna.ai/docs/
MIT License
11.03k stars 860 forks source link

added milvus vectorstore support #448

Closed yushangfu closed 3 months ago

yushangfu commented 4 months ago

added milvus vectorstore support, but need to deploy milvus and embedding model in advance. I tested it in my env, and everything is ok, please check, thanks

peilongchencc commented 4 months ago

I just needed this, thank you for your contribution!🥰

xiaofan-luan commented 3 months ago

thanks for the contribution! really helpful to have this!

zc277584121 commented 3 months ago

Hi @yushangfu , thanks for your contribution. I have reviewed your commit, and found there are still some details to be optimized. So I have opened a https://github.com/yushangfu/vanna/pull/1 on the top of this branch, can you please merge my PR and update this current PR, so that my commit will work together :)

yushangfu commented 3 months ago

@zc277584121 Hi, Could you please ask @zainhoda to help you review your code? Currently I moved to another project, I have no Milvus env to test your code. Sorry for that

zainhoda commented 3 months ago

@zc277584121 feel free to open a new PR from your branch

zc277584121 commented 3 months ago

@zainhoda https://github.com/vanna-ai/vanna/pull/496 thanks

zainhoda commented 3 months ago

Closing in favor of #496