search

vanng822 / go-premailer

Inline styling for html mail in golang
MIT License
141 stars 20 forks source link

`/x/net/http` upgrade breaking change #16

Closed gzuidhof closed 6 months ago

gzuidhof commented 2 years ago

I added a test case that breaks when you upgrade golang.org/x/net, which broke the Hermes e-mail templating package downstream.

This requires a downstream update of goquery, and /x/net/http. I believe that /x/net/http was resolved, but Goquery hasn't upgraded yet https://github.com/PuerkitoBio/goquery/issues/391. After it has, the version here should be bumped too.

bensie commented 2 years ago

Seeing the same issue here, where conditional comments are broken:

Old output

<!--[if mso]>\n      <style type=\"text/css\">\n...

New (bad) output

<!--[if mso]&gt;\n      &lt;style type=&#34;text/css&#34;&gt;\n...
vanng822 commented 2 years ago

Can anyone help me following those issues and upgrades? thanks

bensie commented 1 year ago

After additional digging, this issue is not resolved in x/net. I've added a note to https://github.com/golang/go/issues/46261 indicating where the bug was introduced.

vanng822 commented 6 months ago

dependabot upgraded golang.org/x/net https://github.com/vanng822/go-premailer/pull/20 and it seems work fine?

vanng822 commented 6 months ago

Look like tests passed if I upgraded golang.org/x/net to v0.23.0. Could you try it out then I can merge this instead of of #20

vanng822 commented 6 months ago

Look like it works fine so I will merge.