Fix rule sorting by specificity

vanng822 / go-premailer

Inline styling for html mail in golang

MIT License

139 stars 19 forks source link

Fix rule sorting by specificity #4

Closed korya closed 7 years ago

korya commented 7 years ago

The bug appears only on lists with more than 6 elements due to sort.Sort implementation. For more details refer to quickSort() imlementation in https://golang.org/src/sort/sort.go#L185

korya commented 7 years ago

The tests have failure is not related to the changes introduced in this PR. The failed test case is TestNotSupportedSelectors, the reason it fails is the change in goquery API. The test case is fixed in a separate PR: https://github.com/vanng822/go-premailer/pull/5.

vanng822 commented 7 years ago

Thanks @korya