search

vanng822 / go-solr

Solr client in Go, core admin, add docs, update, delete, search and more
MIT License
69 stars 42 forks source link

Reuse the http connections in connection pool instead of initiating client connection for each request #34

Closed djinn closed 8 years ago

vanng822 commented 8 years ago

Thank for the PR @djinn This is great, one off the thing on my list. Would this change enough or should we do something more?

Let's see what has been changed in dev that make the tests failed. Maybe we just run for 1.4 and 1.5 instead of tip?

djinn commented 8 years ago

Let me run the test case myself to check. Ideally it should reduce number of solr back end connections

On Mon, 28 Dec 2015 16:11 Nguyen Van Nhu notifications@github.com wrote:

Thank for the PR @djinn https://github.com/djinn This is great, one off the thing on my list. Would this change enough or should we do something more?

Let's see what has been changed in dev that make the tests failed. Maybe we just run for 1.4 and 1.5 instead of tip?

— Reply to this email directly or view it on GitHub https://github.com/vanng822/go-solr/pull/34#issuecomment-167518445.

djinn commented 8 years ago

Just checked the travis output. It seems that the error text has changed between 1.4 and tip. Otherwise this is good to go.

vanng822 commented 8 years ago

Yes @djinn I saw that and have also run on v1.5 so I suggest that we only run for stable versions of go, let's run only for 1.4 and 1.5. Do you want to make this change in .travis.yml? Would be nice if we do this first before merging

djinn commented 8 years ago

Sure.

On Mon, Dec 28, 2015 at 4:54 PM, Nguyen Van Nhu notifications@github.com wrote:

Yes @djinn https://github.com/djinn I saw that and have also run on v1.5 so I suggest that we only run for stable versions of go, let's run only for 1.4 and 1.5. Do you want to make this change in .travis.yml? Would be nice if we do this first before merging

— Reply to this email directly or view it on GitHub https://github.com/vanng822/go-solr/pull/34#issuecomment-167531419.

Supreet Sethi Ph US: +19173102635 Ph IN: +919811143517 Code: http://osrc.dfm.io/djinn Ph Skype: d_j_i_n_n Profile: http://www.google.com/profiles/supreet.sethi Twt: http://twitter.com/djinn

vanng822 commented 8 years ago

Look like didn't help but the output is ok. I merge and rewrite the tests to use regexp instead

Thank you for your help!