search

vanng822 / go-solr

Solr client in Go, core admin, add docs, update, delete, search and more
MIT License
69 stars 42 forks source link

Made appropriate change for fixing variable error report #35

Closed djinn closed 8 years ago

vanng822 commented 8 years ago

Great, I have some time so I was thinking fixing the tests but you are already there. Sorry for not waiting for your answer.

There were 2 files that need to fix. I guess you have to time to help with the second file as well

vanng822 commented 8 years ago

I was on the way to introduce github.com/stretchr/testify/assert Regexp github.com/stretchr/testify/assert provide really good assertions functionalities :-)

djinn commented 8 years ago

Strangely these errors are not showing up on my setup. I use 1.5.1

djinn commented 8 years ago

Good to go now. Assert will be a great idea.

vanng822 commented 8 years ago

not my either, it must have to do with the dns resolver settings in travis.

Thank for helping, I merge

Yeah, this is my first golang project for learning so there is a lot of thing we can improve