search

vanng822 / go-solr

Solr client in Go, core admin, add docs, update, delete, search and more
MIT License
69 stars 42 forks source link

Adding Spellcheck support to go-solr #37

Closed nitsanfiverr closed 8 years ago

nitsanfiverr commented 8 years ago

Adding spellcheck support to go-solr search - https://wiki.apache.org/solr/SpellCheckComponent Added tests and tested it locally with my solr.

vanng822 commented 8 years ago

Hi @nitsanfiverr Thanks for the PR. It looks like that the tests didn't pass.

Unfortunately those tests are running on a mock server which mimics the response to each test You can find response data and how it was setup in mock_test.go

nitsanfiverr commented 8 years ago

@vanng822 Hey There, thanks for the tip, I didn't notice the mock server. The tests are now passing, added one more test to check if the component is not there.

vanng822 commented 8 years ago

Yeah, it should be documented since it is not clear. I would like to use https://github.com/jarcoal/httpmock instead, will do when I have time, will more clear and isolated tests.

Look like everything is fine. I will merge. Thanks for your contribution