search

vanng822 / gps-util

GPS related functionalities for nodejs
MIT License
33 stars 14 forks source link

gpxParse for file without time attributes #7

Closed alexdonei closed 8 years ago

alexdonei commented 8 years ago

Hi, When i try to parse a GPX file downloaded by Strava like track, no one point found. I have check the file GPX and the code inside gpx-parse.js and I found this problem: when the code is analyzing a point, check if the point has the time attribute, but in my file this attribute is not present. I resolved locally by creating a new module, gpxParseTrack, that call an internal function that not check the presence of attributes time.

Why you check the presence of the time attibute? You can modify the library to check the file GPX without this attibute? Maybe as an option. Thank you

vanng822 commented 8 years ago

Don't remember exact but I guess we can make it optional. Parse only if it is there

vanng822 commented 8 years ago

@alexdonei it should be fixed in v1.0.1 Try it out.

I needed it for showing the timeline but look like optional in the spec v1.1

alexdonei commented 8 years ago

Works, great! Thank you! Alex

Il giorno 07/giu/2016, alle ore 21:28, Nguyen Van Nhu notifications@github.com ha scritto:

@alexdonei https://github.com/alexdonei it should be fixed in v1.0.1 Try it out.

I needed it for showing the timeline but look like optional in the spec v1.1

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vanng822/gps-util/issues/7#issuecomment-224387883, or mute the thread https://github.com/notifications/unsubscribe/AJrVKQW7WfTPkao2XiHH47HaJgFO2WRRks5qJcZHgaJpZM4Iv_re.