popupWindowHeight does not seem to have any effect on the displayed hight

vanniktech / Emoji

A library to add Emoji support to your Android / iOS / JVM Application

Apache License 2.0

1.52k stars 291 forks source link

popupWindowHeight does not seem to have any effect on the displayed hight #1008

Closed singpolyma closed 1 month ago

singpolyma commented 11 months ago

Thank you for filing an issue. If this is a bug that you want to report, please take the time to provide some information:

Version of the library: com.vanniktech:emoji-google:0.18.0-SNAPSHOT
Affected devices: emulator

Using SearchInPlaceTrait and the popup window is quite large (most of the vertical space) would prefer it be smaller, but settings popupWindowHeight on the EmojiPopup I pass to the trait does not seem to have any effect.

vanniktech commented 11 months ago

I think the popupWindowHeight is only meant to be for the actual EmojiPopup. Are you currently setting that one and want it to be respected or do you want another customization point (in which case we should add it to the SearchInPlaceTrait constructor).

singpolyma commented 11 months ago

I'm not clear on how the "actual EmojiPopup" differs from the one being shown by the SearchInPlaceTrait but either way I'm just looking for a way to limit the height so it doesn't cover most of the screen while searching

vanniktech commented 7 months ago

Can you share a screenshot of the SearchInPlaceTrait that you think that is too big?