search

vanniktech / gradle-android-junit-jacoco-plugin

Gradle plugin that generates JaCoCo reports from an Android Gradle Project
http://vanniktech.com
Apache License 2.0
399 stars 72 forks source link

Fix StackOverflowError with Gradle 5.0 regarding FileCollection #151

Closed Laimiux closed 5 years ago

Laimiux commented 5 years ago

Fixing issue discussed in: https://github.com/vanniktech/gradle-android-junit-jacoco-plugin/issues/136

codecov[bot] commented 5 years ago

Codecov Report

Merging #151 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #151   +/-   ##
=========================================
  Coverage     87.86%   87.86%           
  Complexity       38       38           
=========================================
  Files             1        1           
  Lines           173      173           
  Branches         24       24           
=========================================
  Hits            152      152           
  Misses           13       13           
  Partials          8        8
Impacted Files Coverage Δ Complexity Δ
...ktech/android/junit/jacoco/GenerationPlugin.groovy 87.86% <100%> (ø) 38 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b72e78b...f5e1c2d. Read the comment docs.

wiyarmir commented 5 years ago

Any plans to cut a release including this fix? 😄 Thanks!

vanniktech commented 5 years ago

According to https://github.com/vanniktech/gradle-android-junit-jacoco-plugin/issues/139#issuecomment-473673651 not all cases have been fixed and I haven't had time to look into it yet.

wiyarmir commented 5 years ago

Oh! I see. Let me know if you want help with anything 🙂

vanniktech commented 5 years ago

If you can find the issue and create a PR with a fix I'd be super grateful.