search

vanniktech / gradle-android-junit-jacoco-plugin

Gradle plugin that generates JaCoCo reports from an Android Gradle Project
http://vanniktech.com
Apache License 2.0
399 stars 72 forks source link

After gradle 5.1.1 upgrade, "mergeJacocoReports" task is failing in multi module project #156

Closed vasdeepika closed 5 years ago

vasdeepika commented 5 years ago

Hi, We have multi module project. I am using the latest released version(0.14.0) of this plugin. When I run mergeJacocoReports task then build is failing with the below error: No signature of method: org.gradle.api.internal.file.CompositeFileCollection$1.setFrom() is applicable for argument types: (ArrayList) values: [[/Users/xxx/build/jacoco/testDebugUnitTest.exec]]

If I change realExecutionData assignment in mergeTask then it works fine Existing code: doFirst { // Filter non existing files. def realExecutionData = project.files().asFileTree .....

Modified code: doFirst { // Filter non existing files. def realExecutionData = project.files() ..... Can you look into this and let me know why this is failing for me?

Thanks!

vanniktech commented 5 years ago

Huh interesting. Can you try out 0.15.0-SNAPSHOT?

The code change to do is probably safe to do. Wondering why it's failing though. Which version of Gradle were you running before?

vasdeepika commented 5 years ago

Thanks for the quick response! Seeing the same error in 0.15.0-SNAPSHOT too. Before I was using 4.10.1 version of Gradle.

vanniktech commented 5 years ago

Do you mind creating a PR with your fix? I can merge and then it'll be fixed in the new version.

vasdeepika commented 5 years ago

PR is open. Please merge it when you have time.

vanniktech commented 5 years ago

Thank you. Fixed by #157

howtimeflies-io commented 5 years ago

Hi @vanniktech, could you please make a new release for this fix? Thank you.