search

vanniktech / gradle-android-junit-jacoco-plugin

Gradle plugin that generates JaCoCo reports from an Android Gradle Project
http://vanniktech.com
Apache License 2.0
399 stars 72 forks source link

Fixed code coverage for android tests #168

Closed VysotskiVadim closed 4 years ago

VysotskiVadim commented 4 years ago

See the issue description at #167

I don't know how to write a gradle plugins in proper way, but even if the PR is terrible, I hope it at least inspires you to make a good solution.

codecov[bot] commented 4 years ago

Codecov Report

Merging #168 into master will decrease coverage by 4%. The diff coverage is 11.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #168      +/-   ##
============================================
- Coverage     88.06%   84.06%   -4.01%     
  Complexity       43       43              
============================================
  Files             1        1              
  Lines           176      182       +6     
  Branches         24       24              
============================================
- Hits            155      153       -2     
- Misses           13       21       +8     
  Partials          8        8
Impacted Files Coverage Δ Complexity Δ
...ktech/android/junit/jacoco/GenerationPlugin.groovy 84.06% <11.11%> (-4.01%) 43 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b2f3d6...ead7a7f. Read the comment docs.

vanniktech commented 4 years ago

What do you think @vRallev ? To be honest, I'm a bit lost at this point with Gradle, AGP and what this plugin does

vRallev commented 4 years ago

Same here. I don't mind merging it as is. I don't see how it could break the plugin.