search

vanniktech / gradle-android-junit-jacoco-plugin

Gradle plugin that generates JaCoCo reports from an Android Gradle Project
http://vanniktech.com
Apache License 2.0
399 stars 72 forks source link

Kotlin Build Scripts: Property shouldn't be immutable #187

Closed jonatbergn closed 3 years ago

jonatbergn commented 3 years ago

Apparently when configuring the plugin in kotlin build scripts, one cannot assign ignoreProjects:

junitJacoco {
    ignoreProjects = arrayOf("ignored-project")
//  ^ Val cannot be reassigned
}

Make ignoreProjects of type List<String>, instead of String[]. I suppose then one could configure it as follows:

junitJacoco {
    ignoreProjects = listOf("ignored-project")
}
codecov[bot] commented 3 years ago

Codecov Report

Merging #187 (98011b7) into master (8615af9) will increase coverage by 0.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #187      +/-   ##
============================================
+ Coverage     83.59%   83.68%   +0.08%     
  Complexity       45       45              
============================================
  Files             3        3              
  Lines           189      190       +1     
  Branches         25       25              
============================================
+ Hits            158      159       +1     
  Misses           22       22              
  Partials          9        9
Impacted Files Coverage Δ Complexity Δ
...h/android/junit/jacoco/JunitJacocoExtension.groovy 100.00% <100.00%> (ø) 1.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8615af9...98011b7. Read the comment docs.