search

vanniktech / gradle-android-junit-jacoco-plugin

Gradle plugin that generates JaCoCo reports from an Android Gradle Project
http://vanniktech.com
Apache License 2.0
400 stars 76 forks source link

Gradle 8 upgrade #223

Open john-tadebois opened 10 months ago

john-tadebois commented 10 months ago

I pushed this branch from themockgrateme:gradle-8-upgrade, with the fix for

POM_IMPLEMENTATION_CLASS = com.vanniktech.android.junit.jacoco.GenerationPlugin

Along with themockgraeme's changes:

https://github.com/vanniktech/gradle-android-junit-jacoco-plugin/pull/219

I forked the Laimiux Gradle 8 compatible branch of the Vanniktech Jacoco plugin and made the following changes:

Removed the Laimiux publishing calls, which are specific to their system. Upgraded the included APIs to the latest versions and made minor code changes to accommodate these. Changed the Java / JDK version to 17, for compatibility with Gradle 8. Upgraded the Gradle version to 8.

john-tadebois commented 10 months ago

@themockgraeme I have added the code review changes from https://github.com/vanniktech/gradle-android-junit-jacoco-plugin/pull/219.

I could not push to your branch, so I created this one. Could you please give it a quick review?

unamed000 commented 9 months ago

Hey guys ....

This seem to take forever to merge, do we have any workarounds for this until this is merged?

cc @john-tadebois john

john-tadebois commented 8 months ago

Hey guys ....

This seem to take forever to merge, do we have any workarounds for this until this is merged?

cc @john-tadebois john

I do not know much about the inner workings of this plugin.

My team has moved on to directly use JaCoCo.

I can still merge that PR if you do understand and can confirm in this chat that I can go ahead and merge this PR.