search

vanshg / MacAssistant

Google Assistant for macOS!
MIT License
1.62k stars 125 forks source link

Swift 4 Upgrades + Travis CI Integration #52

Closed harens closed 6 years ago

harens commented 6 years ago

RootsEncoder, gRPC.framework, gRPCTests.xctest and zlib-example converted to Swift 4. A .travis.yml has been written and tested, whilst some of the documentation has been corrected.

vanshg commented 6 years ago

Hey @harens, thank you for the pull request! I've just pushed an update that begins a revamp of the project. With it, I've upgraded to Swift 4 and essentially started from scratch for the new project. Can you take a verify that the Travis CI would still work and update the PR?

harens commented 6 years ago

Thanks @vanshg for your response. I would be more than happy to check if Travis CI would still work, though I'll send it as a separate PR.

vanshg commented 6 years ago

Awesome thanks @harens!

harens commented 6 years ago

@vanshg I am having some trouble building the project. I was wondering how you've built it with the updated submodules?

vanshg commented 6 years ago

Hm I don't think you would even need the submodules. They're only used for generation of the grpc files, which I've already generated and included. Did you run a pod install?

vanshg commented 6 years ago

(btw, the commands in the README are out of date right now)