vanstinator / raincloudy

RainCloudy is a library written in Python 3.x that manages the Melnor RainCloud Smart Garden Watering Irrigation Timer.
Apache License 2.0
24 stars 7 forks source link

Add asyncio implementation #53

Closed eavanvalkenburg closed 2 years ago

eavanvalkenburg commented 3 years ago

Hi @vanstinator, I've been looking at improving the component for HA for raincloud, and noticed I needed to do some stuff in the package as well, most importantly in creating a asyncio version of the package which HA prefers to work with.

Have a look and let me know what you think!

In this initial version:

eavanvalkenburg commented 3 years ago

Yeah I'll work on the tests, since of the quotes and stuff is because I use black formatting...

eavanvalkenburg commented 3 years ago

No problem @vanstinator, the hard work was already done! Can you create a new release (maybe pre-release) with this functionality?

vanstinator commented 2 years ago

Apologies for letting this drop off my radar. Fall gets busy and my sprinklers get packed for the winter. I'm starting to prep for spring and that includes dusting off the raincloud home assistant bits to make sure it all works yet 😅. If you're still in the raincloud ecosystem and interested in landing this I can start moving forward.

eavanvalkenburg commented 2 years ago

Still using it, so would love to improve on it!

vanstinator commented 2 years ago

I've set up a new Github Actions workflow and it'll automatically publish pre-release builds to pypi on commits to master. So you should be able to start pulling this down almost immediately. And when you're happy with the state of the async bits I can cut a full stable release

eavanvalkenburg commented 2 years ago

Thanks @vanstinator mine is also in storage now, so will pick this back up once spring arrives here!