search

vanstyn / RapidApp

Turnkey ajaxy webapps
http://rapi.io
Other
48 stars 15 forks source link

Source tree has an obnoxious mix of `<CR>` and `<CR><LF>` line endings #154

Open ribasushi opened 9 years ago

ribasushi commented 9 years ago

If there is no opposition on principle, I'd like to convert the source tree to a strict <CR> regime. Besides the obvious changes (which are invisible under git blame -w) the change would also involve adding this snippet ensuring Windows git checkouts are correct and a dist-time test modeled on the DBIC counterpart

vanstyn commented 9 years ago

So I assume you meant to say <LF> ...

But, to address the actual point, the reason I haven't done this yet is for the history issue, which you pointed out. git blame isn't a goto for me, and I don't want to have to do something different for ever more to browse/diff just for the sake of fixing this issue (I rely very heavily on browsing the history of code changes). My current plan to fix this is by attrition -- all new files and new commits already default to <LF>, as well as defaulting to spaces instead of tabs (both of which are obnoxiously mixed, for this reason). As classes get refactored, the old styles get purged...

I've been on the fence on this issue for quite a long time, and have gone back and forth on it. I came to the conclusion, that at least for now, I don't want to pull the trigger on purging these old styles because of what it would mean to my convenient diff/history ...

There is a major refactor planned for the DbicLnk sub-system, and after I get past this I may revisit this topic (that process itself will automatically fix a lot of it, and once we get to that point, the old styles which remain will likely be less important enough that I can feel safe doing a wholesale change...)

I'm leaving this issue open because I do acknowledge that this IS an issue... its just not one I'm ready to fix, yet :-)

ribasushi commented 9 years ago

Fair enough, thanks for looking.